Skip to content

feat(todo): add dedicated TodoApp component with checklist UI, reorder, due dates #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hognek wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat(todo): add dedicated TodoApp component with checklist UI, reorder, due dates #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c31cb6
feat(todo): add dedicated TodoApp component with checklist UI, reorde…
hognek Jul 17, 2026
5659267
fix(todo): address Kilo review — error display, creating state cleanup
hognek Jul 17, 2026
f704cc8
fix(todo): reorder within visible section + validate items before setDoc
hognek Jul 17, 2026
3d2625d
fix(todo): guard duplicate submissions, serialize toggles, improve er…
hognek Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions desktop/src/apps/NotesApp.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { render, screen, act, waitFor, within, fireEvent } from "@testing-library/react";
import { describe, it, expect, vi, beforeEach } from "vitest";
import { NotesApp, TodoApp } from "./NotesApp";
import { NotesApp } from "./NotesApp";

function mockFetch(
resolver: (url: string, init?: RequestInit) => { ok: boolean; status?: number; body: unknown },
Expand Down Expand Up @@ -178,27 +178,3 @@ describe("NotesApp", () => {
});
});

describe("TodoApp", () => {
beforeEach(() => {
vi.restoreAllMocks();
});

it("renders only lists, filtering out notes that share the same API", async () => {
vi.stubGlobal(
"fetch",
mockFetch(() => ({ ok: true, body: [noteDoc, listDoc] })),
);
render(<TodoApp windowId="w2" />);
await flush();

await waitFor(() => expect(screen.getByText("Sprint backlog")).toBeTruthy());
expect(screen.queryByText("Project kickoff")).toBeNull();
});

it("shows the todo empty state when there are no lists", async () => {
vi.stubGlobal("fetch", mockFetch(() => ({ ok: true, body: [] })));
render(<TodoApp windowId="w2" />);
await flush();
await waitFor(() => expect(screen.getByText(/no lists yet/i)).toBeTruthy());
});
});
18 changes: 0 additions & 18 deletions desktop/src/apps/NotesApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { useState, useEffect, useCallback, useRef } from "react";
import {
StickyNote,
ListChecks,
Plus,
Clock,
Users,
Expand Down Expand Up @@ -119,19 +118,6 @@ const NOTES_CONFIG: DocKindConfig = {
showDone: false,
};

const TODO_CONFIG: DocKindConfig = {
kind: "list",
appName: "Todo",
icon: ListChecks,
noun: "list",
titlePlaceholder: "List title...",
addPlaceholder: "Add a task...",
emptyDocs: "No lists yet.",
emptyEntries: "Nothing here yet. Add your first task above.",
selectPrompt: "Select a list to get started.",
showDone: true,
};

// ---- Sub-components ----

function MemberBadge({ member }: { member: NoteMember }) {
Expand Down Expand Up @@ -1171,7 +1157,3 @@ function DocsApp({ config }: { config: DocKindConfig }) {
export function NotesApp({ windowId: _windowId }: { windowId: string }) {
return <DocsApp config={NOTES_CONFIG} />;
}

export function TodoApp({ windowId: _windowId }: { windowId: string }) {
return <DocsApp config={TODO_CONFIG} />;
}
Loading
Loading