Skip to content

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites#4

Merged
jazz127 merged 1 commit intojazz127:devfrom
bradygaster:squad/835-team-root-all-commands
Apr 5, 2026
Merged

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites#4
jazz127 merged 1 commit intojazz127:devfrom
bradygaster:squad/835-team-root-all-commands

Conversation

@jazz127
Copy link
Copy Markdown
Owner

@jazz127 jazz127 commented Apr 5, 2026

All commands now respect SQUAD_TEAM_ROOT env var for subprocess compatibility. Previously only nap, status, and cost used getSquadStartDir().

Closes bradygaster#835
Related: PR bradygaster#763, bradygaster#734

What

Why

How


PR Readiness Checklist

The PR readiness bot will validate these automatically after push.
Check each item before requesting review. See CONTRIBUTING.md for full details.

Branch & Commit

  • Branch created from dev (not main)
  • Branch is up to date with dev (git fetch upstream && git rebase upstream/dev)
  • PR is not in draft mode (mark ready when checks pass)
  • Commit history is clean (squash fixups before review)

Build & Test

  • npm run build passes
  • npm test passes (all tests green)
  • npm run lint passes (type check clean)
  • npm run lint:eslint passes
  • For migration PRs (>20 files): include test output summary in PR description

Changeset

  • Changeset added via npx changeset add (if packages/squad-sdk/src/ or packages/squad-cli/src/ changed)
  • Or direct CHANGELOG.md entry (maintainers only — write-protected for external contributors)
  • Or skip-changelog label applied (if no user-facing changes)

Docs

  • README section updated (if new feature/module)
  • Docs feature page (if new user-facing capability)

Exports

  • package.json subpath exports updated (if new module)

Breaking Changes

Waivers

All commands now respect SQUAD_TEAM_ROOT env var for subprocess compatibility.
Previously only nap, status, and cost used getSquadStartDir().

Closes #835
Related: PR #763, #734

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit f25c8b9

⚠️ 3 item(s) to address before review

Status Check Details
Single commit 1 commit — clean history
Not in draft Ready for review
Branch up to date dev is 7 commit(s) ahead — rebase recommended
Copilot review No Copilot review yet — it may still be processing
Changeset present Changeset file found
Scope clean No .squad/ or docs/proposals/ files
No merge conflicts No merge conflicts
Copilot threads resolved No Copilot review threads
CI passing 13 check(s) still running

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@jazz127 jazz127 merged commit 9f0afea into jazz127:dev Apr 5, 2026
15 of 16 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

🟡 Impact Analysis — PR #4

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 2
Files added 1
Files modified 1
Files deleted 0
Modules touched 2

🎯 Risk Factors

  • 2 files changed (≤5 → LOW)
  • 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (1 file)
  • .changeset/fix-team-root-all-commands.md
squad-cli (1 file)
  • packages/squad-cli/src/cli-entry.ts

This report is generated automatically for every PR. See #733 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites

2 participants