feat: Add try/jupyter page #129
Conversation
|
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Pull Request Overview
This PR transforms the /try page into a comprehensive entry point for trying JBang, offering users a choice between a quick JDoodle experience and a full-featured Jupyter notebook environment with support for custom GitHub repositories and Gists.
- Split the original
/trypage into two distinct options: JDoodle for quick testing and Jupyter for interactive development - Added a Jupyter notebook environment with custom URL generator for user repositories
- Created comprehensive use cases documentation and getting started guide
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| content/try.md | Refactored to display two try options with styled cards and links to specific environments |
| content/try/jdoodle.md | Extracted original JDoodle functionality into dedicated page |
| content/try/jupyter.md | New interactive page with form-based custom Jupyter link generator |
| content/use-cases.md | New comprehensive documentation showing JBang usage across different skill levels |
| content/getting-started.md | New guide providing quick installation and first steps with JBang |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (repoUrl.includes('gist.github.com')) { | ||
| // Handle Gist URLs - use the original Gist URL directly | ||
| githubUrl = repoUrl; | ||
| branch = branchInput.value.trim() || 'main'; | ||
| } else if (repoUrl.includes('github.com')) { | ||
| // Handle regular GitHub URLs | ||
| githubUrl = repoUrl.replace(/\.git$/, ''); | ||
| branch = branchInput.value.trim() || 'main'; | ||
| } else { | ||
| alert('Please enter a valid GitHub repository or Gist URL'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
The URL validation logic is overly simplistic. Consider using proper URL parsing with new URL() and checking the hostname property to handle edge cases like subdomains or different protocols more robustly.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 participant
This splits /try into linking to "old" jdoodle and add option for jupyter notebook llaunch.
Also adds a /try/jupyter which lets you generate url for your own repo to edit/view via jupyter notebook