Add a default allocator argument to the protocol primary template (3/20) - #103
Open
jbcoe wants to merge 1 commit into
Open
Add a default allocator argument to the protocol primary template (3/20)#103jbcoe wants to merge 1 commit into
jbcoe wants to merge 1 commit into
Conversation
jbcoe
changed the title
jbcoe
marked this pull request as ready for review
July 28, 2026 10:56
jbcoe
force-pushed
the
reflection/01-rename-vtable-fns
branch
from
July 28, 2026 18:27
1ba3f41 to
b40322a
Compare
jbcoe
force-pushed
the
reflection/02-default-allocator
branch
from
July 28, 2026 18:27
17a08ff to
5ed8351
Compare
jbcoe
force-pushed
the
reflection/01-rename-vtable-fns
branch
from
July 28, 2026 20:22
b40322a to
df6a602
Compare
jbcoe
force-pushed
the
reflection/02-default-allocator
branch
from
July 28, 2026 20:22
5ed8351 to
b85d3af
Compare
RyanJK5
self-requested a review
July 29, 2026 00:20
RyanJK5
approved these changes
Jul 29, 2026
Moves the std::allocator<T> default from the definition to the forward declaration, so protocol<T> is valid wherever only the declaration is visible. A default can't be repeated on the same parameter, so the definition drops its own.
jbcoe
force-pushed
the
reflection/01-rename-vtable-fns
branch
from
July 29, 2026 09:48
df6a602 to
00d7249
Compare
jbcoe
force-pushed
the
reflection/02-default-allocator
branch
from
July 29, 2026 09:48
b85d3af to
943ed1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the std::allocator default from the definition to the
forward declaration, so protocol is valid wherever only the
declaration is visible. A default can't be repeated on the same
parameter, so the definition drops its own.