Add interface B alongside C, and fix vtable_entry_name over-escaping (15/20) - #115
Draft
jbcoe wants to merge 1 commit into
Draft
Add interface B alongside C, and fix vtable_entry_name over-escaping (15/20)#115jbcoe wants to merge 1 commit into
jbcoe wants to merge 1 commit into
Conversation
jbcoe
changed the title
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 11:33
252c3a2 to
74a2f40
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 11:33
aabb1fb to
6becbf8
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 14:22
74a2f40 to
96fa91f
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 14:22
6becbf8 to
35e8e4e
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 14:29
96fa91f to
0c46cf3
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 14:30
35e8e4e to
b569ee3
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 15:14
0c46cf3 to
5645a91
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 15:14
b569ee3 to
f725170
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 15:28
5645a91 to
7f1977b
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 15:28
f725170 to
0193b27
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 18:27
7f1977b to
0ce30ba
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 18:27
0193b27 to
ad6dea2
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 19:37
0ce30ba to
8fa585b
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 19:37
ad6dea2 to
5106225
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 28, 2026 20:23
8fa585b to
f1954b2
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 28, 2026 20:23
5106225 to
9af9b2a
Compare
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 29, 2026 09:48
f1954b2 to
ffa81d8
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 29, 2026 09:48
9af9b2a to
5557271
Compare
vtable_entry_name was escaping literal underscores in already-valid identifiers, turning is_ready into is_5fready; it now returns a named member's identifier verbatim. vtable_slot_name, which needs that escaping for non-identifier signature strings, is unaffected.
jbcoe
force-pushed
the
reflection/13-overload-merging
branch
from
July 29, 2026 10:14
ffa81d8 to
636937a
Compare
jbcoe
force-pushed
the
reflection/14-interface-b
branch
from
July 29, 2026 10:14
5557271 to
188bff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vtable_entry_name was escaping literal underscores in already-valid
identifiers, turning is_ready into is_5fready; it now returns a
named member's identifier verbatim. vtable_slot_name, which needs
that escaping for non-identifier signature strings, is unaffected.