Fix a clang-format-induced parse break in three erased_call_thunk uses (19/20) - #119
Draft
jbcoe wants to merge 1 commit into
Draft
Conversation
jbcoe
changed the title
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 11:33
9d0f043 to
ccf7f63
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 11:33
e8e79e8 to
9cb2d3e
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 14:22
ccf7f63 to
357f971
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 14:23
9cb2d3e to
d4ef8ba
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 14:27
357f971 to
1e62cfd
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 14:27
d4ef8ba to
9d38cca
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 14:30
1e62cfd to
442c07b
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 14:30
9d38cca to
7de2afc
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 15:14
442c07b to
45cd500
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 15:14
7de2afc to
b6104b2
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 15:29
45cd500 to
53df339
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 15:29
b6104b2 to
5d85448
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 18:27
53df339 to
1ca29c9
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 18:27
5d85448 to
4b171ca
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 19:37
1ca29c9 to
db2a0dd
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 19:38
4b171ca to
f938b89
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 28, 2026 20:23
db2a0dd to
cd1661a
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 28, 2026 20:23
f938b89 to
bdc5116
Compare
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 29, 2026 09:48
cd1661a to
7207351
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 29, 2026 09:48
bdc5116 to
796befc
Compare
clang-format sometimes wraps a typename[: :] splice across a line break between ':' and ']', which GCC 16 trunk's splice parser misparses, producing a wrong-argument-count error at an unrelated call site. Guards the three affected instantiations with // clang-format off/on.
jbcoe
force-pushed
the
reflection/17-protocol-view
branch
from
July 29, 2026 10:14
7207351 to
0e0d4bb
Compare
jbcoe
force-pushed
the
reflection/18-fix-clang-format-splice-break
branch
from
July 29, 2026 10:14
796befc to
e92ea3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format sometimes wraps a typename[: :] splice across a line
break between ':' and ']', which GCC 16 trunk's splice parser
misparses, producing a wrong-argument-count error at an unrelated
call site. Guards the three affected instantiations with
// clang-format off/on.