Skip to content

Fix missing configuration that leads to ctest failures on MSVC #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbcoe merged 9 commits into from
Jul 19, 2026
Merged

Fix missing configuration that leads to ctest failures on MSVC #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a5f7a0
Attempt to prevent MSVC from corrupting JSON
jbcoe Jul 19, 2026
0d937ad
Add explicit configuration for test builds
jbcoe Jul 19, 2026
66f6218
Attempt to prevent MSVC from corrupting JSON
jbcoe Jul 19, 2026
af75996
Suppress action validator issues
jbcoe Jul 19, 2026
5549cd9
Suppress action validator issues
jbcoe Jul 19, 2026
469bf13
Suppress action validator issues
jbcoe Jul 19, 2026
4869645
Attempt to prevent MSVC from corrupting JSON
jbcoe Jul 19, 2026
0b398cf
Reduce scope of changes
jbcoe Jul 19, 2026
315a44a
Fix CMake presets
jbcoe Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,4 @@ jobs:
- name: Test
# Execute tests defined by the CMake configuration.
# See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
run: ctest --preset ${{ matrix.configuration }}
run: ctest --preset ${{ matrix.configuration }} -C ${{ matrix.configuration }}
2 changes: 1 addition & 1 deletion .github/workflows/integrity_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
submodules: true

- name: Install action-validator with asdf
uses: asdf-vm/actions/install@v3
uses: asdf-vm/actions/install@v4
with:
tool_versions: |
action-validator 0.5.1
Expand Down
4 changes: 2 additions & 2 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
{ "name": "Release", "displayName": "Release", "configurePreset": "Release", "configuration": "Release" }
],
"testPresets": [
{ "name": "Debug", "displayName": "Debug", "configurePreset": "Debug" },
{ "name": "Release", "displayName": "Release", "configurePreset": "Release" }
{ "name": "Debug", "displayName": "Debug", "configurePreset": "Debug", "configuration": "Debug" },
{ "name": "Release", "displayName": "Release", "configurePreset": "Release", "configuration": "Release" }
]
}
Loading