Update gitbookInfo.R and checkForGitbook.R#22
Open
raulossada wants to merge 7 commits intojbryer:masterfrom
Open
Update gitbookInfo.R and checkForGitbook.R#22raulossada wants to merge 7 commits intojbryer:masterfrom
raulossada wants to merge 7 commits intojbryer:masterfrom
Conversation
Using the version proposed by benmarwick.
Using `npm list -g` instead of `gitbook --version` since it seems that the later one needs some special permission to execute directly from RStudio in Windows 8.1 x64. Although running `cmd` and using `gitbook --version` works fine.
Using https instead of ssh to avoid firewalss and proxy issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitbookInfo.R: Usingnpm list -ginstead ofgitbook --versionsince it seems that the later one needs some special permission to execute directly from RStudio in Windows 8.1 x64. Although runningcmdand usinggitbook --versionworks fine.checkForGitbook.R: Instead of usingnpmI propose usingnpm -vto check if npm is installed, since it returns a status 0 and also its version.initGitbook.R: Code proposed by benmarwick. Sorry I thought that I would be able to submit just the first 2 codes.Windows 8.1 x64 - RStudio 0.98.953 - R 3.1.1