fix: Relativize paths in examples/**/*.map.json#46
Open
davewa wants to merge 1 commit intojbuehler23:mainfrom
Open
fix: Relativize paths in examples/**/*.map.json#46davewa wants to merge 1 commit intojbuehler23:mainfrom
davewa wants to merge 1 commit intojbuehler23:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
Manually changed the *.map.json files, replacing absolute file paths with assets-path-relative paths to the same files. Also changed all
\\to/in paths.Testing
Passes all PR checks:
cargo run --example collision_demoworks correctly on macOS 26.3.1 (Apple M2), and Windows 11 (aarch64).Notes
This only edits the
*.map.jsonfiles in theexamples/folder, there are no code changes. Creating a new project using the editor still writes absolute paths into the.map.jsonfile for the project. I'd prefer to address that in a separate PR, possibly using diff_paths to handle creating relative paths to files outside of the assets folder.