Skip to content

Remove note on total accreted masses #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jchelly merged 1 commit into from
May 26, 2026
Merged

Remove note on total accreted masses #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/snapshots/snapshot_particle_properties.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ HDF5 datasets which store the following particle properties:
+-------------------------------------------+---------+------------+---------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ``SubgridMasses`` | float32 | N | :math:`10^{10} \mathrm{M}_\odot` | Subgrid masses of the particles |
+-------------------------------------------+---------+------------+---------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ``TotalAccretedMasses`` | float32 | N | :math:`10^{10} \mathrm{M}_\odot \mathrm{Mpc}^{-1} \mathrm{km/s}` | Total mass accreted onto the particles since its birth. :ref:`The units are incorrect for the Jet & Jet_fgas−4σ runs <issues_total_accreted_masses>`. |
| ``TotalAccretedMasses`` | float32 | N | :math:`10^{10} \mathrm{M}_\odot` | Total mass accreted onto the particles since its birth. |
+-------------------------------------------+---------+------------+---------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ``Velocities`` | float32 | N,3 | :math:`\mathrm{km/s}` | Peculiar velocities of the particles. This is :math:`a * dx/dt` where :math:`x` is the co-moving position of the particle. |
+-------------------------------------------+---------+------------+---------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
Expand Down
8 changes: 0 additions & 8 deletions source/support/support_issues.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,6 @@ Starting with HDF5 version 1.14.4, datasets with a :ref:`compression filter
<faq_compression>` which compresses the data by more than 2x are flagged as problematic.
This affects the following fields in the snapshots ``PartType0/MaximalTemperatures``, ``PartType0/ElectronNumberDensities``. The h5py python package does not currently support the option to disable this flag, so a version built with ``HDF5 < 1.14.4`` must be used.

.. _issues_total_accreted_masses:

Incorrect units for ``TotalAccretedMasses``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The field ``TotalAccretedMasses`` in the Jet & Jet_fgas-4σ runs have units of :math:`10^{10}\mathrm{M}_\odot` rather than :math:`10^{10} \mathrm{M}_\odot \mathrm{Mpc}^{-1} \mathrm{km/s}`. The stored values should be treated as if they did have the correct units.


Halo catalogues
---------------

Expand Down
Loading