Open
Conversation
Updated Logger module Added slighty needless Package Requirements to README Signed-off-by: Aiden Woodruff <aiden.woodruff@gmail.com>
jchuahtacc
requested changes
May 10, 2018
Owner
jchuahtacc
left a comment
jchuahtacc
left a comment
There was a problem hiding this comment.
Line 18: That has to be kept as HOST = None otherwise it won't auto scan for a valid network interface
Line 76: What's the intended effect of removing s.bind(('', 0))?
Set Host to None Re-added bind call Signed-off-by: Aiden Woodruff <aiden.woodruff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Logger module
Added slighty needless Package Requirements to README
Fixed socketserver import
Updated dict iteration
Signed-off-by: Aiden Woodruff aiden.woodruff@gmail.com