Skip to content

Fix crash with _GLIBCXX_ASSERTIONS #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hfiguiere wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash with _GLIBCXX_ASSERTIONS #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WECore/SongbirdFilters/SongbirdFilterModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ namespace WECore::Songbird {
Vowel SongbirdFilterModule<T>::getVowelDescription(int val) const {
Vowel tempVowel;

std::copy(&_allFormants[val - 1][0],
&_allFormants[val - 1][NUM_FORMANTS_PER_VOWEL],
std::copy(_allFormants[val - 1].begin(),
_allFormants[val - 1].end(),
Copy link
Author

@hfiguiere hfiguiere May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be fair, I'm pretty sure the whole function can be rewrtiten as

    Vowel SongbirdFilterModule<T>::getVowelDescription(int val) const {
        return _allFormants[val - 1];
    }

std::begin(tempVowel));

return tempVowel;
Expand Down