Fix a bug in demo code and add a demo for custom embedding_function#28
Open
conanak99 wants to merge 3 commits into
Open
Fix a bug in demo code and add a demo for custom embedding_function#28conanak99 wants to merge 3 commits into
conanak99 wants to merge 3 commits into
Conversation
Owner
|
Can this be run locally on cpu only? |
Owner
|
I would like to avoid adding dependencies just for the purpose of demos. |
Author
|
hi @jdagdelen , it can be run on CPU only, I understand the concern about adding new dependencies. Fixed that, add a comment in the demo so people know which dependencies to install instead :D One more thing to note is the embedding from local model is not as good as OpenAI, based on my test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resultof this line indemo/demo.pyreturns a list oftuple(document, similarity), so the demo code will not work correctly. This is fixed in this PR..OPENAI_API_KEY. Addeddemo/demo_custom_embed.pythat makes use of SentenceTransformers/ to generate embedding, which can be run locally.