Skip to content

Use dir .. for shell detection on Windows instead of uname -s #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GilgameshxZero wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use dir .. for shell detection on Windows instead of uname -s #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions src/serverSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,23 +42,16 @@ export async function installCodeServer(conn: SSHConnection, serverDownloadUrlTe

// detect platform and shell for windows
if (!platform || platform === 'windows') {
const result = await conn.exec('uname -s');
const result = await conn.exec('dir ..');

if (result.stdout) {
if (result.stdout.includes('windows32')) {
platform = 'windows';
} else if (result.stdout.includes('MINGW64')) {
platform = 'windows';
shell = 'bash';
}
} else if (result.stderr) {
if (result.stderr.includes('FullyQualifiedErrorId : CommandNotFoundException')) {
platform = 'windows';
}

if (result.stderr.includes('is not recognized as an internal or external command')) {
platform = 'windows';
platform = 'windows';
if (result.stdout.includes('LastWriteTime')) {
shell = 'powershell';
} else if (result.stdout.includes('<DIR>')) {
shell = 'cmd';
} else {
shell = 'bash';
}
}

Expand Down