Update Base64SecretPatternFactory.java#347
Draft
AbhinavJha1023 wants to merge 1 commit intojenkinsci:masterfrom
Draft
Update Base64SecretPatternFactory.java#347AbhinavJha1023 wants to merge 1 commit intojenkinsci:masterfrom
AbhinavJha1023 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Replaced loops with Streams: Improved readability and performance. Used collect(Collectors.toSet()): Eliminates duplicates. Optimized removeTrailingEquals: Uses charAt check instead of multiple conditions. Encapsulation: Marked helper methods as private for better structure.
Member
|
the code does not compile. |
Author
Let me check this once again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced loops with Streams: Improved readability and performance.
Used collect(Collectors.toSet()): Eliminates duplicates.
Optimized removeTrailingEquals: Uses charAt check instead of multiple conditions.
Encapsulation: Marked helper methods as private for better structure.
Testing done
Submitter checklist