Fixes #365

[mukundsrinivasb]

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

My objective
figure out how the cli parameters are read into java , and which .java files parse them. I was under the impression that getPlugins() method in the CliOptions.java file would be responsible for all of it.

I am stuck
Running the jenkins-plugin-cli -p git verboses nothing, however it should verbose the name of the plugin after -p . In this case git.

Relevent links
Relevent Issues

[krisstern]

Hi @mukundsrinivasb Thanks for your code contribution!

It appears that you have some (namely two) bugs in your code. You can check these out say tat https://github.com/jenkinsci/plugin-installation-manager-tool/pull/548/checks?check_run_id=12083885842, where you have:

1. io.jenkins.tools.pluginmanager.cli.CliOptionsTest.setupPluginsTest: A Null Pointer Exception at io.jenkins.tools.pluginmanager.util.PluginListParser.isHpi(PluginListParser.java:191)
2. io.jenkins.tools.pluginmanager.util.PluginListParserTest.parsePluginTxtFileTest: Another Null Pointer Exception at io.jenkins.tools.pluginmanager.util.PluginListParser.isHpi(PluginListParser.java:191)

So it appears if you could handle the NPE exception at io.jenkins.tools.pluginmanager.util.PluginListParser.isHpi(PluginListParser.java:191) properly the failures to build should go away.

[mukundsrinivasb]

I shall get to it right away

[krisstern]

Hi @mukundsrinivasb Maybe you should add the line Fixes #365 or Closes #365 to the pull request description so that GitHub will add the issue to the Development section on the pane on the right hand side. And maybe change your pull request title to something like Fixes #365 instead to make it more descriptive.

[mukundsrinivasb]

add the line Fixes #365 or Closes #365 to the pull request description so that GitHub will add the issue to the Development section on the pane on the right hand side.

How to check weather this change has taken effect?. Also I've added the fixes #365 to the title

[krisstern]

Your syntax is not correct, it has to be literally Fixes #365 or Closes #365 on its own line in the pull request description. Your issue will show up in the Development section on the right hand side once it has been done properly. Now it is showing None Yet: