Fix findPluginsToDownload falsely check installed version#657
Open
anhcraft wants to merge 1 commit intojenkinsci:masterfrom
Open
Fix findPluginsToDownload falsely check installed version#657anhcraft wants to merge 1 commit intojenkinsci:masterfrom
anhcraft wants to merge 1 commit intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
PluginManager#findPluginsToDownloadhas a wrong logic if-else. For a requested plugin, if there is both installed plugin and bundled plugin, then the method only gets the version from the installed one without checking if the bundled one is newer. The else logic was added in c445deaTesting done
I have adjusted the test case to suit the new changes.
Submitter checklist