Open
Conversation
Add: 1. Validate user for group membership. If in group listed in opfgroups.txt then validate password, else ignore. if no groups listed then validate everyone. 2. Validate password for regex match. See opfregex.txt file. 3. Add support for username in OpenPasswordFilter.dll and OPFService 4. Replace List array with Hash array - faster lookup 5. Additional Logging (some refactoring) 6. Change compile target to NET 4.5.2
with opfregex.txt and opfgroups.txt file details
Contributor
|
Nice. I didn't see a way to piggy back on your PR, but I used it to add checks that the user's name doesn't appear in the password. Cheers! |
Author
|
Good add.
Yeah there’s no real ‘settings’ for this tool. That would probably be a helpful next step. Then someone can choose to enable/disable the various features.
Besides, hoping that original owner will pull these various changes into the master.
From: Robert Brock [mailto:notifications@github.com]
Sent: June 16, 2017 9:34 AM
To: jephthai/OpenPasswordFilter <OpenPasswordFilter@noreply.github.com>
Cc: Craig Debbo <cdebbo@kcdsb.on.ca>; Author <author@noreply.github.com>
Subject: Re: [jephthai/OpenPasswordFilter] Add Group validation, Regex Check (#10)
Nice. I didn't see a way to piggy back on your PR, but I used it to add checks that the user's name doesn't appear in the password. Cheers!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#10 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFbIs6VB6iT3U96xDA1wSGHES-Y8ux3Dks5sEpJYgaJpZM4NJZqX>.
This e-mail is confidential and intended only for the use of the recipient to whom it is addressed. If you have received this e-mail by mistake, please let me know by e-mail reply and delete it from your system.
|
Owner
|
I certainly plan to. I'm just now coming off of a long travel schedule, but
should be able to catch up soon.
…On Jun 16, 2017 8:58 AM, "Craig Debbo" ***@***.***> wrote:
Good add.
Yeah there’s no real ‘settings’ for this tool. That would probably be a
helpful next step. Then someone can choose to enable/disable the various
features.
Besides, hoping that original owner will pull these various changes into
the master.
From: Robert Brock ***@***.***
Sent: June 16, 2017 9:34 AM
To: jephthai/OpenPasswordFilter ***@***.***>
Cc: Craig Debbo ***@***.***>; Author ***@***.***>
Subject: Re: [jephthai/OpenPasswordFilter] Add Group validation, Regex
Check (#10)
Nice. I didn't see a way to piggy back on your PR, but I used it to add
checks that the user's name doesn't appear in the password. Cheers!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/
jephthai/OpenPasswordFilter#10#issuecomment-309042229>, or mute the
thread<https://github.com/notifications/unsubscribe-auth/
AFbIs6VB6iT3U96xDA1wSGHES-Y8ux3Dks5sEpJYgaJpZM4NJZqX>.
This e-mail is confidential and intended only for the use of the recipient
to whom it is addressed. If you have received this e-mail by mistake,
please let me know by e-mail reply and delete it from your system.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEYlQV1zwYfUYXrtSpdAUKMAhtWMcpd4ks5sEqY7gaJpZM4NJZqX>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: Support for username validation and password regex validation.
Specifically -