Do not log full request when bad response code is received#79
Do not log full request when bad response code is received#79jesperfj merged 2 commits intojesperfj:masterfrom
Conversation
The request object potentially contains sensitive information. For requests resulting in a bad response code, log only the response code and the request URL.
|
@jesperfj please review when you have a moment |
|
Thanks for this pull. I think this is good "hygiene" change. But it could make it harder to debug problems. In your opinion, would some people have a harder time debugging the cause of the error when they cannot see the full request? Should we solve that with a |
|
This is now released to 0.0.43 |
That's possible, but at a minimum authentication headers should always be removed: #76 . Also, PII should be removed. It might be hard to enumerate where sensitive information such as PII can be present, so there is some risk with debug logging. |
The request object potentially contains sensitive information. For
requests resulting in a bad response code, log only the response code
and the request method and URL.