Add an optional ShouldHandleMouseEvent hook#100
Merged
stefanhaller merged 2 commits intomasterfrom Mar 8, 2026
Merged
Conversation
This shouldn't make a difference right now, but it makes it possible to disable switching tabs when a modal panel is open, but still handle clicks on hyperlinks in inactive views behind the panel, which is useful.
This allows clients to reject clicks, which can be useful for disabling background views while a modal panel is open. Doing this client-side in a keybinding handler would not be enough, because it would still set the cursor position in the clicked view, and it would still handle clicks on tab headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows clients to reject clicks, which can be useful for disabling
background views while a modal panel is open. Doing this client-side in a
keybinding handler would not be enough, because it would still set the cursor
position in the clicked view, and it would still handle clicks on tab headers.