Open
Conversation
Also use typeInference for tests case
Use private helper method to calculate randomNumbers
Use Int instead of String
Constrain the generic type to conform to Equatable. Move extension and ExpectedAssertion to its own file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
The aim of this PR is to improve the readability of the unit tests and to add missing assertion to test expectations.
Considerations and implementation
Readability has been improved by splitting tests into separate classes and files and also by avoiding the use of nested classes.
DRY principle applied by using of generics and extensions.
Testing
Create a new value type to for async expectation and assertions.
Test that Insertions and deletions are happening at the expected indexes.