Pbench Tool Registration and Output file argument#1
Open
kdvalin wants to merge 15 commits intojharriga:mainfrom
Open
Pbench Tool Registration and Output file argument#1kdvalin wants to merge 15 commits intojharriga:mainfrom
kdvalin wants to merge 15 commits intojharriga:mainfrom
Conversation
…rates as expected
jharriga
reviewed
Apr 2, 2024
Owner
jharriga
left a comment
jharriga
left a comment
There was a problem hiding this comment.
in 'pbench_scripts/vars.sh' I'd suggest adding Redfish login credentials
- rf_username
- rf_password
Once thats complete I'd like time to see these changes in action
Perhaps we could setup some screen sharing time
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces scripts to use this tool as a Pbench tool. As a result, a handler for the SIGTERM signal was added to handle scenarios where the process was
kill'd.A new option was added
--outputallowing the output file to be in a different path and have a different name than the defaultResults_<UTC TIME>.json.