Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions packages/java-parser/api.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,6 @@ export abstract class JavaCstVisitor<IN, OUT> implements ICstVisitor<IN, OUT> {
param?: IN
): OUT;
isDims(ctx: IsDimsCtx, param?: IN): OUT;
isFollowingVariableDeclarator(
ctx: IsFollowingVariableDeclaratorCtx,
param?: IN
): OUT;
compilationUnit(ctx: CompilationUnitCtx, param?: IN): OUT;
ordinaryCompilationUnit(ctx: OrdinaryCompilationUnitCtx, param?: IN): OUT;
modularCompilationUnit(ctx: ModularCompilationUnitCtx, param?: IN): OUT;
Expand Down Expand Up @@ -503,10 +499,6 @@ export abstract class JavaCstVisitorWithDefaults<IN, OUT>
param?: IN
): OUT;
isDims(ctx: IsDimsCtx, param?: IN): OUT;
isFollowingVariableDeclarator(
ctx: IsFollowingVariableDeclaratorCtx,
param?: IN
): OUT;
compilationUnit(ctx: CompilationUnitCtx, param?: IN): OUT;
ordinaryCompilationUnit(ctx: OrdinaryCompilationUnitCtx, param?: IN): OUT;
modularCompilationUnit(ctx: ModularCompilationUnitCtx, param?: IN): OUT;
Expand Down Expand Up @@ -1802,16 +1794,6 @@ export type IsDimsCtx = {
RBrace?: IToken[];
};

export interface IsFollowingVariableDeclaratorCstNode extends CstNode {
name: "isFollowingVariableDeclarator";
children: IsFollowingVariableDeclaratorCtx;
}

export type IsFollowingVariableDeclaratorCtx = {
Comma: IToken[];
variableDeclarator: VariableDeclaratorCstNode[];
};

export interface CompilationUnitCstNode extends CstNode {
name: "compilationUnit";
children: CompilationUnitCtx;
Expand Down
4 changes: 2 additions & 2 deletions packages/java-parser/src/productions/blocks-and-statements.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ export function defineRules($, t) {
});

// https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-LocalVariableDeclaration
$.RULE("localVariableDeclaration", () => {
$.RULE("localVariableDeclaration", isSingleDeclarator => {
$.MANY(() => {
$.SUBRULE($.variableModifier);
});
$.SUBRULE($.localVariableType);
$.SUBRULE($.variableDeclaratorList);
$.SUBRULE($.variableDeclaratorList, { ARGS: [isSingleDeclarator] });
});

// https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-LocalVariableType
Expand Down
26 changes: 4 additions & 22 deletions packages/java-parser/src/productions/classes.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,12 @@ export function defineRules($, t) {
});

// https://docs.oracle.com/javase/specs/jls/se22/html/jls-8.html#jls-VariableDeclaratorList
$.RULE("variableDeclaratorList", () => {
$.RULE("variableDeclaratorList", isSingleDeclarator => {
$.SUBRULE($.variableDeclarator);
$.MANY({
// required to distinguish from patternList
GATE: () => this.BACKTRACK_LOOKAHEAD($.isFollowingVariableDeclarator),
// TypePattern has a semantic requirement that its VariableDeclaratorList
// consists of a single VariableDeclarator
GATE: () => !isSingleDeclarator,
DEF: () => {
$.CONSUME(t.Comma);
$.SUBRULE2($.variableDeclarator);
Expand Down Expand Up @@ -729,23 +730,4 @@ export function defineRules($, t) {
tokenMatcher(this.LA(1), t.LSquare) && tokenMatcher(this.LA(2), t.RSquare)
);
});

/*
* The following sequence can either be a variable declarator or a component pattern if next token is a comma
* This check if the following sequence is **not** a component pattern sequence
*/
$.RULE("isFollowingVariableDeclarator", () => {
const hasDims =
tokenMatcher(this.LA(3), t.LSquare) &&
tokenMatcher(this.LA(4), t.RSquare);
const offset = hasDims ? 2 : 0;
if (
tokenMatcher(this.LA(offset + 3), t.Identifier) ||
tokenMatcher(this.LA(offset + 3), t.Underscore)
) {
return false;
}

return !tokenMatcher(this.LA(3), t.LBrace);
});
}
2 changes: 1 addition & 1 deletion packages/java-parser/src/productions/expressions.js
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ export function defineRules($, t) {

// https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-TypePattern
$.RULE("typePattern", () => {
$.SUBRULE($.localVariableDeclaration);
$.SUBRULE($.localVariableDeclaration, { ARGS: [true] });
});

// https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-RecordPattern
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,9 @@ describe("Pattern matching", () => {
javaParser.parse(input, "componentPatternList")
).to.not.throw();
});

it("should parse switch label with multiple qualified case patterns", () => {
const input = "case b.B _, c.C _";
expect(() => javaParser.parse(input, "switchLabel")).to.not.throw();
});
});
5 changes: 0 additions & 5 deletions packages/prettier-plugin-java/src/printers/classes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ import {
FormalParameterListCtx,
InstanceInitializerCtx,
InterfaceTypeListCtx,
IsFollowingVariableDeclaratorCtx,
IToken,
MethodBodyCtx,
MethodDeclarationCtx,
Expand Down Expand Up @@ -1072,8 +1071,4 @@ export class ClassesPrettierVisitor extends BaseCstPrettierPrinter {
isDims() {
return "isDims";
}

isFollowingVariableDeclarator() {
return "isFollowingVariableDeclarator";
}
}