Initial attempt to add a no-array-mutation rule#5
Open
davidgtonge wants to merge 2 commits intojhusain:masterfrom
Open
Initial attempt to add a no-array-mutation rule#5davidgtonge wants to merge 2 commits intojhusain:masterfrom
davidgtonge wants to merge 2 commits intojhusain:masterfrom
Conversation
added 2 commits
March 14, 2016 02:02
Currently a simplistic check that looks for calls of array methods that mutate. Not restricted to arrays currently so will actually block any method calls with push, pop, splice, shift, unshift, reverse
|
This would be a welcome PR. What is the status of this? |
Owner
|
Not confident that this change wouldn't negatively impact users of ImmutableJS. Unfortunately I don't think we can assume that methods with the same name as the Array methods are mutating. maybe if confirm there is nothing capturing the return value this would be safe. Seems like a prohibition on that would encompass this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This is currently a simplistic check that looks for calls of array methods that mutate.
Not restricted to arrays currently so will actually block any method calls with push, pop, splice, shift, unshift or reverse, e.g. this currently warns if I use
const newArray = R.reverse(array)I'm new to Eslint and so I'm not sure if there is a way to make this check more specific to arrays.