feat(test): add #[cfg(feature = 'slow-tests')] to slow tests#10
Merged
feat(test): add #[cfg(feature = 'slow-tests')] to slow tests#10
Conversation
Update .config/nextest.toml, check_coverage.sh, and quality_check.sh to support --full flag and slow-tests feature. See #9. Signed-off-by: CHEN, CHUN <jim60105@gmail.com>
Mark all 14 slow tests with #[cfg(feature = 'slow-tests')] and add feature config to Cargo.toml. See #9. Signed-off-by: CHEN, CHUN <jim60105@gmail.com>
Add --full to quality_check.sh and check_coverage.sh, and --features slow-tests to coverage generation. See #9. Signed-off-by: CHEN, CHUN <jim60105@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
- Combine coverage generation and threshold enforcement into a single workflow step by calling the check_coverage.sh script with the new --lcov option and setting COVERAGE_THRESHOLD - Remove the old, separate “Check coverage threshold” job to streamline CI coverage checks - Add LCOV_OUTPUT_PATH support and a --lcov flag in check_coverage.sh, with updated usage instructions - Refactor coverage logic to run tests once, then emit LCOV and JSON reports via cargo llvm-cov report, reducing duplicate test runs and improving success/error messages Signed-off-by: CHEN, CHUN <jim60105@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Enhancement] #9 - 慢速測試條件編譯與測試策略優化 工作報告
任務:將執行時間超過 30 秒的慢速測試以 #[cfg(feature = 'slow-tests')] 標記,並於 Cargo.toml 新增 slow-tests feature,配合 nextest 與腳本支援完整/快速測試切換。
類型:Enhancement
狀態:已完成
一、任務概述
本次針對專案中 14 個執行時間超過 30 秒的慢速測試,統一以 Rust feature flag
slow-tests條件編譯,並於 Cargo.toml 新增對應 feature。搭配 nextest.toml 與 scripts/quality_check.sh、scripts/check_coverage.sh,實現本地預設跳過慢速測試,CI 及 --full 參數時完整執行。二、實作內容
2.1 測試條件編譯標記
2.2 Cargo.toml feature 設定
三、技術細節
3.1 架構變更
3.2 API 變更
3.3 配置變更
四、測試與驗證
4.1 程式碼品質檢查
4.2 功能測試
4.3 覆蓋率測試
五、影響評估
5.1 向後相容性
5.2 使用者體驗
六、問題與解決方案
6.1 遇到的問題
6.2 技術債務
七、後續事項
7.1 待完成項目
7.2 相關任務
7.3 建議的下一步
八、檔案異動清單
tests/sync_parameter_combinations_tests.rstests/sync_comprehensive_integration_tests.rstests/sync_batch_subtitle_only_skip_tests.rstests/vad_detector_tests.rstests/sync_first_sentence_offset_integration_tests.rsCargo.toml九、關聯項目
Resolves #9