fix(bibtex): surface lookup failures instead of returning no matches#6
Merged
Conversation
search_bibtex wrapped each source (DBLP, Semantic Scholar) in 'except Exception: return []', so a network outage or API error was indistinguishable from a genuine 'no matches'. Record each source's error and, when every source failed and there are no results, raise so the CLI reports a clear error + non-zero exit (the bibtex command already maps exceptions via handle_http_error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
search_bibtexqueries DBLP and Semantic Scholar directly. Each helper caught every error (timeout, network, API outage) and returned[], so a total outage was indistinguishable from a genuine "no matches" - the command reported no results on what was actually a failed lookup.Fix
_search_dblpand_search_semantic_scholarrecord the failure into anerrorslist instead of silently swallowing it.search_bibtexraisebibtex lookup failed (...). A real empty result (sources reachable, no hits) still returns an empty list.Mirrors the same fix in jina-ai/MCP#26.