Skip to content

🚨 CRITICAL SECURITY FIX: Missing Signer Check in Migration Functions #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riverventures wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

🚨 CRITICAL SECURITY FIX: Missing Signer Check in Migration Functions #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions mev-programs/programs/priority-fee-distribution/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,11 @@ pub mod jito_priority_fee_distribution {
pub fn migrate_tda_merkle_root_upload_authority(
ctx: Context<MigrateTdaMerkleRootUploadAuthority>,
) -> Result<()> {
// SECURITY FIX: Verify that only the config authority can perform migration
if ctx.accounts.config.authority != ctx.accounts.authority.key() {
return Err(Unauthorized.into());
}

let distribution_account = &mut ctx.accounts.priority_fee_distribution_account;
// Validate TDA has no MerkleRoot uploaded to it
if distribution_account.merkle_root.is_some() {
Expand Down Expand Up @@ -708,6 +713,9 @@ impl UpdateMerkleRootUploadConfig<'_> {

#[derive(Accounts)]
pub struct MigrateTdaMerkleRootUploadAuthority<'info> {
#[account(seeds = [Config::SEED], bump)]
pub config: Account<'info, Config>,

#[account(mut, rent_exempt = enforce)]
pub priority_fee_distribution_account: Account<'info, PriorityFeeDistributionAccount>,

Expand All @@ -717,6 +725,8 @@ pub struct MigrateTdaMerkleRootUploadAuthority<'info> {
rent_exempt = enforce,
)]
pub merkle_root_upload_config: Account<'info, MerkleRootUploadConfig>,

pub authority: Signer<'info>,
}

#[derive(Accounts)]
Expand Down
10 changes: 10 additions & 0 deletions mev-programs/programs/tip-distribution/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ pub mod jito_tip_distribution {
pub fn migrate_tda_merkle_root_upload_authority(
ctx: Context<MigrateTdaMerkleRootUploadAuthority>,
) -> Result<()> {
// SECURITY FIX: Verify that only the config authority can perform migration
if ctx.accounts.config.authority != ctx.accounts.authority.key() {
return Err(Unauthorized.into());
}

let distribution_account = &mut ctx.accounts.tip_distribution_account;
// Validate TDA has no MerkleRoot uploaded to it
if distribution_account.merkle_root.is_some() {
Expand Down Expand Up @@ -674,6 +679,9 @@ impl UpdateMerkleRootUploadConfig<'_> {

#[derive(Accounts)]
pub struct MigrateTdaMerkleRootUploadAuthority<'info> {
#[account(seeds = [Config::SEED], bump)]
pub config: Account<'info, Config>,

#[account(mut, rent_exempt = enforce)]
pub tip_distribution_account: Account<'info, TipDistributionAccount>,

Expand All @@ -683,6 +691,8 @@ pub struct MigrateTdaMerkleRootUploadAuthority<'info> {
rent_exempt = enforce,
)]
pub merkle_root_upload_config: Account<'info, MerkleRootUploadConfig>,

pub authority: Signer<'info>,
}

// Events
Expand Down