Skip to content

Fix cast bug in SimpleArray #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkiesele wants to merge 1 commit into from
Closed

Fix cast bug in SimpleArray #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/djcdata/SimpleArray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,13 @@ def createFromNumpy(self, nparr, nprs=np.array([],dtype='int64')):
fnames = self.featureNames()
self._setDtype(str(nparr.dtype))
if nprs.dtype == 'int32':
self.sa.createFromNumpy(nparr, nprs.as_type('int64'))
# numpy arrays use ``astype`` for casting; ``as_type`` does not
# exist and would raise an AttributeError when a rowsplit array
# with int32 dtype is provided. Cast to int64 before passing the
# data to the underlying C++ implementation.
self.sa.createFromNumpy(nparr, nprs.astype('int64'))
else:
self.sa.createFromNumpy(nparr, nprs)
self.sa.createFromNumpy(nparr, nprs)
self.setName(name)
self.setFeatureNames(fnames)

Expand Down