Add camera view shape options#14
Open
BradGroux wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds additional camera framing options (3:2, 2:3, Circle) and centralizes corner-radius computation so the chosen shape renders consistently across the editor preview, interactions (drag shadow), custom camera regions, and export compositing.
Changes:
- Extend
CameraAspectwith 3:2, 2:3, and Circle options and add shared helpers (pickerRows,isCircle,cornerRadius(in:percentage:)). - Update editor UI controls to present aspect options in multiple segmented rows and disable the radius slider for Circle.
- Replace ad-hoc radius calculations with
CameraAspect.cornerRadius(...)in preview layout/interaction and compositor/export code paths.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Reframed/Editor/VideoPreviewContainer+Layout.swift | Uses CameraAspect.cornerRadius(...) to ensure preview masking/shadow paths match the selected shape (including Circle). |
| Reframed/Editor/VideoPreviewContainer+Interaction.swift | Updates drag shadow rounding to respect the selected camera shape consistently while dragging. |
| Reframed/Editor/PropertiesPanel+CameraTab.swift | Presents aspect options using multiple SegmentPicker rows and disables radius control for Circle. |
| Reframed/Editor/EditorTypes.swift | Adds new camera aspects plus shared helpers for picker layout and radius computation (Circle forces 50%). |
| Reframed/Editor/CameraRegionEditPopover.swift | Mirrors the updated aspect selection UI and Circle radius behavior for custom camera regions. |
| Reframed/Compositor/VideoCompositor+InstructionBuilder.swift | Computes exported camera corner radius via CameraAspect.cornerRadius(...) for consistent output rendering. |
| Reframed/Compositor/FrameRenderer+Helpers.swift | Applies the same corner-radius logic when resolving custom camera regions during rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #13
Validation