replace argonaut with foreign-generic#11
Open
shmish111 wants to merge 1 commit intojmackie:masterfrom
Open
Conversation
|
For this reason I still stick to Argonaut and as such, prefer those to still be in place. |
Author
|
@jvliwanag there is https://pursuit.purescript.org/packages/purescript-foreign-generic/10.0.0/docs/Foreign.Generic#v:decodeJSON etc for dealing with JSON, at least the documentation suggests that everything should be valid JSON. If that is not the case then perhaps these functions should be altered. Is this possible inconsistency an issue in datetime-iso? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand everyone uses foreign-generic rather than argonaut these days. I forked this because
Also use spago and hopefully it can go into the package set one day.
Oh I also formatted with purty without even thinking so the diff has a few whitespace changes, I hope that's ok.