Conversation
|
@seanyu4296 thanks for fixing this |
|
Is this good to merge @BebeSparkelSparkel or do you have any comments? |
|
@seanyu4296 Looks exactly like what I did, so I think it is good to go. |
|
v7 is in the package sets now. |
|
I've been away from PureScript world for a while - can you confirm what you need me to do here? Bump the version and publish to |
|
@seanyu4296 do you think this is a major version bump? Kind of hard to tell. |
|
Yeah I'm not sure myself too based from the libraries that were updated purescript/package-sets#651 some did a major version bump, but some did a patch version bump. |
|
hmmm i'm not sure if one can still push updates to |
|
|
|
I just created a PR to convert to foreign-generic without seeing this PR, are people still using argonaut, I thought foreign-generic was "the standard" in purescript these days? |
Hi, I saw that there will be a version upgrade soon in argonaut codecs.
This is a WIP PR. Just putting it here for initial opinions. :) I am not sure if it is "safe" to merge since v7 is not yet in the official package-sets