Skip to content

Upgrade to argonaut codecs 7#8

Open
seanyu4296 wants to merge 2 commits intojmackie:masterfrom
seanyu4296:upgrade-to-argonaut-codecs-7
Open

Upgrade to argonaut codecs 7#8
seanyu4296 wants to merge 2 commits intojmackie:masterfrom
seanyu4296:upgrade-to-argonaut-codecs-7

Conversation

@seanyu4296
Copy link

Hi, I saw that there will be a version upgrade soon in argonaut codecs.

This is a WIP PR. Just putting it here for initial opinions. :) I am not sure if it is "safe" to merge since v7 is not yet in the official package-sets

@seanyu4296
Copy link
Author

@BebeSparkelSparkel
Copy link

@seanyu4296 thanks for fixing this

@seanyu4296
Copy link
Author

Is this good to merge @BebeSparkelSparkel or do you have any comments?

@BebeSparkelSparkel
Copy link

@seanyu4296 Looks exactly like what I did, so I think it is good to go.

@BebeSparkelSparkel
Copy link

v7 is in the package sets now.

@jmackie
Copy link
Owner

jmackie commented Aug 17, 2020

I've been away from PureScript world for a while - can you confirm what you need me to do here? Bump the version and publish to bower?

@BebeSparkelSparkel
Copy link

@seanyu4296 do you think this is a major version bump? Kind of hard to tell.

@seanyu4296 seanyu4296 changed the title WIP: Upgrade to argonaut codecs 7 Upgrade to argonaut codecs 7 Aug 18, 2020
@seanyu4296
Copy link
Author

Yeah I'm not sure myself too based from the libraries that were updated purescript/package-sets#651 some did a major version bump, but some did a patch version bump.
@BebeSparkelSparkel

@seanyu4296
Copy link
Author

hmmm i'm not sure if one can still push updates to bower i haven't tried, but i think the community is leaning now to this approach https://github.com/purescript/package-sets/blob/master/CONTRIBUTING.md using spago @jmackie

@BebeSparkelSparkel
Copy link

or listed in the new-packages in the registry repo. https://github.com/purescript/registry/blob/master/new-packages.json

@shmish111
Copy link

I just created a PR to convert to foreign-generic without seeing this PR, are people still using argonaut, I thought foreign-generic was "the standard" in purescript these days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants