Conversation
Author
|
Done. All working well, builds are ok, tests are ok 2 more things that can be done
|
Author
|
still around @jmesnil ? |
Author
|
I know you dont have much time but I'll really appreciate a review / merge from you @jmesnil ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I started a build umd branch to add AMD / CJS / Global support
Build is ok, have to add minify & clean up the src file to remove previous export and return Stomp object.
Also I was wondering if I could replace lib/stomp.js by the umd build instead of having to files, stomp.js & stomp.umd.js.