Parse heart-beat header only if present#109
Open
bclozel wants to merge 1 commit intojmesnil:masterfrom
bclozel:connected-heartbeat
Open
Parse heart-beat header only if present#109bclozel wants to merge 1 commit intojmesnil:masterfrom bclozel:connected-heartbeat
bclozel wants to merge 1 commit intojmesnil:masterfrom
bclozel:connected-heartbeat
Conversation
According to the STOMP spec, the `heart-beat` header is OPTIONAL and a missing header must be treated as `heart-beat:0,0`. Prior to this changen the STOMP implementation would try to directly `.split()` this header value without checking for its existence first. This commit checks for the existence of the heart-beat header and uses the default value `"0,0"` if it's not set. See: https://stomp.github.io/stomp-specification-1.2.html#Heart-beating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the STOMP spec, the
heart-beatheader is OPTIONAL and amissing header must be treated as
heart-beat:0,0.Prior to this changen the STOMP implementation would try to directly
.split()this header value without checking for its existence first.This commit checks for the existence of the heart-beat header and uses
the default value
"0,0"if it's not set.See: https://stomp.github.io/stomp-specification-1.2.html#Heart-beating