Open
Conversation
Owner
|
Hey @userhas404d, thanks for submitting this PR! I believe this keyring backend should already transparently support using Teleport. I read through the Teleport documentation and found that it can launch a local proxy gateway to communicate with AWS for applications using the AWS SDK: The AWS SDK (ie: Have you encountered issues using the proxy with this library? I would try this myself, but I don't have a Teleport account to test it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @jmkeyes thanks for building and maintaining this project!
Disclaimer: I don't work for gravitational but my org uses teleport heavily
These changes are a result of not being able to easily leverage the teleport client as a credential process via aws config (more details on how this client works available here). I realize not many folks are going to have a use case for this so if you'd prefer that this not get merged I completely understand. I tried to make a point to avoid any major changes to the existing client config and maintained boto3 as the default. Fully testing this without a working teleport implementation is also going to be a challenge but hopefully with it being an optional client config that's not a huge deal.