Skip to content

feat: Add setting to disable git-signing #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmongard merged 1 commit into from
Mar 7, 2025
Merged

feat: Add setting to disable git-signing #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/kotlin/git/semver/plugin/scm/GitProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,17 @@ internal class GitProvider(private val settings: SemverSettings) {
val isCommit = isFormatEnabled(params.commit, settings.releaseCommitTextFormat)
if (isCommit) {
val commitMessage = settings.releaseCommitTextFormat.format(versionString, params.message.orEmpty())
it.commit().setMessage(commitMessage.trim()).call()
val commitCommand = it.commit().setMessage(commitMessage.trim())
settings.gitSigning?.let(commitCommand::setSign) // Set signing if not set to null
commitCommand.call()
}

val isTag = isFormatEnabled(params.tag, settings.releaseTagNameFormat)
if (isTag) {
val name = settings.releaseTagNameFormat.format(versionString)
it.tag().setName(name).setMessage(params.message).call()
val tagCommand = it.tag().setName(name).setMessage(params.message)
settings.gitSigning?.let(tagCommand::setSigned) // Set signing if not set to null
tagCommand.call()
println("Created new local Git tag: $name")
}

Expand Down
3 changes: 2 additions & 1 deletion src/main/kotlin/git/semver/plugin/semver/BaseSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ abstract class BaseSettings(
var releaseTagNameFormat: String = "%s",
var groupVersionIncrements: Boolean = true,
var noDirtyCheck: Boolean = false,
var noAutoBump: Boolean = false
var noAutoBump: Boolean = false,
var gitSigning: Boolean? = null // null means use the jgit default
) : Serializable {
constructor(settings: BaseSettings) : this(
settings.defaultPreRelease, settings.releasePattern, settings.patchPattern, settings.minorPattern,
Expand Down