Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/perfcpp/exception.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <cstdint>
#include <stdexcept>
#include <string>
#include <string_view>

namespace perf {

Expand Down Expand Up @@ -98,7 +99,7 @@ class CannotOpenCounterError final : public std::runtime_error
* @param error_code Error code raised when calling perf_event_open.
* @return Error message that can be thrown to inform the user.
*/
[[nodiscard]] static std::string create_error_message_from_code(std::int64_t error_code);
[[nodiscard]] static std::string_view create_error_message_from_code(std::int64_t error_code);
};

class CannotReadCounter final : public std::runtime_error
Expand Down Expand Up @@ -134,7 +135,7 @@ class IoctlError : public std::runtime_error
~IoctlError() override = default;

protected:
[[nodiscard]] static std::string create_error_message_from_code(std::int64_t error_code);
[[nodiscard]] static std::string_view create_error_message_from_code(std::int64_t error_code);
};

class CannotEnableCounter final : public IoctlError
Expand Down
4 changes: 2 additions & 2 deletions src/exception.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <perfcpp/exception.hpp>
#include <perfcpp/feature.h>

std::string
std::string_view
perf::CannotOpenCounterError::create_error_message_from_code(const std::int64_t error_code)
{
switch (error_code) {
Expand Down Expand Up @@ -37,7 +37,7 @@ perf::CannotOpenCounterError::create_error_message_from_code(const std::int64_t
}
}

std::string
std::string_view
perf::IoctlError::create_error_message_from_code(const std::int64_t error_code)
{
switch (error_code) {
Expand Down