Skip to content

Add RequiredNonEmptyValidator#380

Open
laogao wants to merge 3 commits into
joanpablo:masterfrom
palandatarxcom:required-non-empty-validator
Open

Add RequiredNonEmptyValidator#380
laogao wants to merge 3 commits into
joanpablo:masterfrom
palandatarxcom:required-non-empty-validator

Conversation

@laogao

@laogao laogao commented May 11, 2023

Copy link
Copy Markdown

Connection with issue(s)

Close #377

Solution description

Creates a separate RequiredNonEmptyValidator to cover cases of empty Iterables ,Maps and Sets.

Screenshots or Videos

To Do

  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov

codecov Bot commented May 11, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.91%. Comparing base (711568b) to head (84e0557).
⚠️ Report is 187 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.03%     
==========================================
  Files          69       70       +1     
  Lines        1338     1348      +10     
==========================================
+ Hits         1283     1293      +10     
  Misses         55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequiredValidator to flag empty lists and maps in addition to nulls and empty strings

1 participant