Open
Conversation
Hassan-Riaz
approved these changes
Oct 3, 2022
Hassan-Riaz
suggested changes
Oct 3, 2022
There was a problem hiding this comment.
@ryuuzake
You can have this maxScale passed from font side so its configurable. And of-course there will be a default value
Same configuration will be applied to android as well
Author
|
@Hassan-Riaz I changes the code to pass the |
guilhermesandi
approved these changes
Oct 24, 2022
|
Is this going to be merged/released anytime soon? We are waiting on this functionality and patching the package does not seem like an optimal solution if the fix is here already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scalefrom iOS behaves differently between expo and native. When using expo, thescalevalue is between 0 and 1. But when using native, thescalevalue is above 1.To solve this issue, I proposed to change the
maxScalevalue to 3. The value 3 is suggested in #149.from my testing, it actually doesn't matter to use what value as long as it's above 1