Skip to content

Conversation

@krishi-agrawal
Copy link

Resolves #953

this PR:

  1. implements switch wallet ui in login page
  2. routes switch-wallet functionality to login page

Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
@theborakompanioni
Copy link
Collaborator

Hey @krishi-agrawal!

Thanks for the PR. I really like some of the changes and generally think the approach is fine.
Did you accidentally remove the "Create wallet" button? Also, I do not quite understand the purpose of the AutoLockWrapper component. I think we should generally put more effort into understanding what a good flow would look like that (a) a user expects and (b) fits JMs wallet model (e.g. only one wallet active at a time).

Is it okay for you if we take a little bit more time to think about what functionality the login page should provide?
e.g. one should see if a wallet is active and, if you have the auth token, have the ability to open it immediately. On the other hand, if you do not have the auth token (or an invalid one), have the ability to provide a password to login.
Nonetheless, one should be able to login to other (inactive) wallets as well. Moreover, if any service is active (maker or taker) it should warn the user that logging into a different wallet will terminate the operation.
So.. it is not so trivial after all..

@krishi-agrawal
Copy link
Author

Hi @theborakompanioni , thank you for the detailed review. I did accidentally remove the create wallet button. I will revise my approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants