Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/__tests__/ReflectionMode.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,4 +115,26 @@ describe('ReflectionMode', () => {
expect(dialog).toHaveAttribute('aria-modal', 'true')
expect(dialog).toHaveAttribute('aria-label', expect.stringContaining('Test'))
})

it('preserves all items when adding rapidly without re-render between adds', async () => {
const user = userEvent.setup()
const onUpdate = vi.fn()

// Render with the initial framework — never re-render with updated props
// This simulates rapid adds where React hasn't re-rendered between them
render(<ReflectionMode framework={makeFramework()} onUpdate={onUpdate} onExit={vi.fn()} />)

const input = screen.getByPlaceholderText('Add to "Start"...')

// Add two items rapidly without any re-render in between
await user.type(input, 'First{Enter}')
await user.type(input, 'Second{Enter}')

// The second onUpdate call should include BOTH items, not just "Second"
expect(onUpdate).toHaveBeenCalledTimes(2)
const secondUpdate = onUpdate.mock.calls[1][0]
expect(secondUpdate.quadrants[0].items).toHaveLength(2)
expect(secondUpdate.quadrants[0].items[0].text).toBe('First')
expect(secondUpdate.quadrants[0].items[1].text).toBe('Second')
})
})
10 changes: 8 additions & 2 deletions src/components/ReflectionMode.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,22 @@ export default function ReflectionMode({ framework, onUpdate, onExit }: Reflecti
}
}, [])

const frameworkRef = useRef(framework)
useEffect(() => {
frameworkRef.current = framework
}, [framework])

const handleAdd = useCallback(
(e: React.FormEvent) => {
e.preventDefault()
if (!text.trim()) return
const updated = addItem(framework, activeQuadrant, createItem(text.trim()))
const updated = addItem(frameworkRef.current, activeQuadrant, createItem(text.trim()))
frameworkRef.current = updated
onUpdate(updated)
setText('')
inputRef.current?.focus()
},
[text, activeQuadrant, framework, onUpdate],
[text, activeQuadrant, onUpdate],
)

const handleKeyDown = useFocusTrap(overlayRef, onExit)
Expand Down