fix: reject pickJsonFile promise when user cancels file picker#4
Merged
Merged
Conversation
The cancel event on <input type="file"> was not handled, leaving the promise pending forever when the user dismissed the file dialog. Add an oncancel handler that rejects with a descriptive error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for golden-scone-6bfeb1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Cancelling a file picker is a normal user action, not an error. Resolve with null so callers can silently ignore it rather than surfacing an error to the user. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pickJsonFile()insrc/io.tsleft its Promise pending forever when the user cancelled the file dialog, sinceonchangenever fires on cancelinput.oncancelhandler to reject the Promise with a descriptive errorsrc/__tests__/io.test.tswith tests for both the happy path and cancel pathCloses BUG-002.
Test plan
🤖 Generated with Claude Code