fix: use meaningful fallback in delete announcement#8
Merged
Conversation
When an item is not found during deletion (race condition), the announcement now says "item" instead of an empty string, avoiding unhelpful "Item "" deleted from ..." messages for screen reader users. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for golden-scone-6bfeb1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
When the item is missing (race condition), announce "Item deleted from ..." cleanly instead of including awkward placeholder text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'item'in delete announcement when item is not found (race condition)Item "" deleted from ...screen reader messagesTest plan
🤖 Generated with Claude Code