fix: validate and sanitize JSON file imports#9
Merged
jonathan-beebe merged 1 commit intoMar 29, 2026
Conversation
Extract sanitizeImportedFramework() that validates quadrant structure, defaults missing labels/colors/items, filters items without text, and ensures x/y coordinates are numbers. Prevents malformed JSON files from being persisted to localStorage and crashing the app. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for golden-scone-6bfeb1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeImportedFramework()pure function inlogic/framework.tstext, defaults missingx/yto 10, generates missingid/createdAtTest plan
sanitizeImportedFrameworkcovering: null/invalid input, missing name, wrong quadrant count, valid input, missing labels, missing colors, missing items array, missing coordinates, items without text, missing item IDs, missing axes🤖 Generated with Claude Code