Merged
Conversation
Now that we're on a version of PureScript that supports poly-kinded types, we don't even have to think about `Data.Symbol.SProxy _`, `Type.Data.RowList.RLProxy _`, or whatever the next iteration of that stuff is. We can instead make our internal `Option.Proxy` poly-kinded, and not deal with the shuffling from `purescript-prelude`. We update the tests to use `Type.Proxy.Proxy _`, since the tests are supposed to be validating the public API and making sure it works with the larger PureScript ecosystem.
`Data.Symbol.SProxy`, `Type.Data.RowList.RLProxy`, and similar mono-kinded proxies are deprecated in PureScript 0.14.x and removed in PureScript 0.15.x. They have been replaced with a single poly-kinded `Type.Proxy.Proxy`. We update the comments to mention this new world instead of referencing things that don't exist anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Data.Symbol.SProxy,Type.Data.RowList.RLProxy, and similar mono-kinded proxies are deprecated in PureScript 0.14.x and removed in PureScript 0.15.x. Now that we're on a version of PureScript that supports poly-kinded types, we don't even have to think aboutData.Symbol.SProxy _,Type.Data.RowList.RLProxy _, or whatever the next iteration of that stuff is. We can instead make our internalOption.Proxypoly-kinded, and not deal with the shuffling frompurescript-prelude.We update the tests to use
Type.Proxy.Proxy _, since the tests are supposed to be validating the public API and making sure it works with the larger PureScript ecosystem. We also update the comments to mention this new world instead of referencing things that don't exist anymore.Testing
This does not change the kinds/types of anything that is exported. The changes to the test are not from required behavioral changes, but only to stay in line with the larger PureScript ecosystem. CI compiling/tests passing should give us enough confidence that we're doing the right thing.