Remove redundant CA option call #69
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In order to properly use HTTPS connections, a valid and up-to-date CA file is needed. That can either be a single file or a directory holding multiple files.
In our CURL transport, a protected method
setCAOptionAndValuefetches the correct file OR folder and sets the respective CURL option.However, a redundant call in the request method tried to do the same, however without checking if the return from CaBundle is a path and not a file.
On systems where CaBundle returns a path, the following error message is shown while fetching extension updates wiht debug mode on:
An error has occurred: error setting certificate file: /PATH/TO/CERTSTesting Instructions
Code Review
Documentation Changes Required