[5.4] Backward Compatibility Module

[alikon]

Pull Request for Issue #46400 .

Summary of Changes

This module displays the which Joomla! Backward Compatibility plugins are enabled and is intended to be displayed in the 'status' position.

Testing Instructions

use the Prebuilt package of this pr

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Its missing sql to add it to the extensions and assets tables on update

[richard67]

Its missing sql to add it to the extensions and assets tables on update

@brianteeman Assets table we never insert on updates and leave that to the asset being created when the settings are saved. But with the extensions table you are right.

[brianteeman]

Its missing sql to add it to the extensions and assets tables on update

@brianteeman Assets table we never insert on updates and leave that to the asset being created when the settings are saved. But with the extensions table you are right.

Doesnt that lead to missing assets

[richard67]

Its missing sql to add it to the extensions and assets tables on update

@brianteeman Assets table we never insert on updates and leave that to the asset being created when the settings are saved. But with the extensions table you are right.

Doesnt that lead to missing assets

@brianteeman Yes, but that's not a problem as modules inherit from the component (part before the first dot in the asset name), so when you have no asset and now edit the module settings and save, the asset will be created exactly in that way. So when we added modules in update SQL scripts in past, we always added the extension record with asset id zero to the extensions table.

[richard67]

@alikon The name of the MySQL update script is still wrong, it contains a dot in the date where there should be a dash.

[richard67]

@alikon See alikon#144 for a proposal for more version agnostic code.

[exlemor]

@alikon, I'm retesting this PR but I seem to have found a bug (perhaps one that wasn't there earlier or that I missed can't remember) - either that or I'm going crazy.

With the PR applied, I see the🛡️Backward: 5, 6 message next to the 5.4.2-dev... for whatever reason, instead of going to went to the Plugins page: https://www.domain.com/_j540/administrator/index.php?option=com_plugins&view=plugins, I went to the Manage Extensions page: https://www.domain.com/_j540/administrator/index.php?option=com_installer&view=manage, I pulled up the keyword: Backward and got 3 lines:

Behaviour - Backward Compatibility - Plugin
Behaviour - Backward Compatibility 6 - Plugin
Joomla! Backward Compatibility Information - Module

and here's the RUB, when I clicked on the Status ✅ on Behaviour - Backward Compatibility 6, the menu's 🛡️Backward: 5, 6 stayed the SAME - unless my brain is fried, I would expect it to show: 🛡️Backward: 5, IF I go into the Plugins page and deactivate Behaviour - Backward Compatibility 6 from there, the status changes to 🛡️Backward: 5 as I expect...

[alikon]

unable to replicate work as expected

[muhme]

I have tested this item ✅ successfully on 717f31d

• Tested using JBT with all the defaults: PHP 8.4.15, MariaDB 10.6.23, Debug System, Error Reporting Maximum, Log Almost Everything
  • graft full package
  • Shows no, Backward 5, Backward 6, Backward 5+6 correctly
    • Different order as in shown expected result, but this doesn't hurt me
    • 
  • No log entries, module 'Backward Compatibility' is correct shown in Administrator modules
• Reinstalled Joomla w/ PostgreSQL 15.8
  • Shows no, Backward 5, Backward 6, Backward 5+6 correctly
    • Different order as in shown expected result, but this doesn't hurt me
    • 
  • No log entries, module 'Backward Compatibility' is correct shown in Administrator modules
• Reinstalled Joomla w/ MySQL 8.1.0
  • Shows no, Backward 5, Backward 6, Backward 5+6 correctly
    • Same (different) order as with MariaDB
  • No log entries, module 'Backward Compatibility' is correct shown in Administrator modules

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46424.}

[exlemor]

I have tested this item ✅ successfully on 717f31d

I have successfully tested this PR. (Now it's working perfect ;) ) Thanks @alikon.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46424.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46424.}

[richard67]

RTC as it has 2 successful human tests ... but as it is a new feature I've also set the RMDQ (release managers decision queue) to flag that it needs a further decision if it shall be merged or be moved to 6.1-dev. We will decide that soon.

[muhme]

In maintainer meeting we discussed this PR and it was decided not to integrate it into 5.4 or at all. The reason for this is that the information may be misleading, the information is irrelevant when the website is working, behavier plugins are checked during the update, and the information for 'Behaviour - Backward Compatibility' plugin, including the settings, is already included in the system information.

Nevertheless, thank you very much to @alikon for contribution, @richard67 for support and @exlemor for testing.

[alikon]

bad decision imho

[alikon]

better if the maintainer can close issues before someone come out with a pr and spend times for nothing