fix bug #224: Bitmap constructor crash with float dimensions#225
Merged
Conversation
The constructor floored w/h into this.width/height but still used the raw float values for the Uint8Array allocation and fill loop. When the float was just above an integer (e.g. 1100.00027), the loop reached i=1100 which equaled this.width, causing validate_coords to throw "Invalid Index: x N >= width N". Fixed by using this.width/this.height consistently after the floor assignment. Added test/bugs/bug_224.test.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor floored w/h into this.width/height but still used the raw float values for the Uint8Array allocation and fill loop. When the float was just above an integer (e.g. 1100.00027), the loop reached i=1100 which equaled this.width, causing validate_coords to throw "Invalid Index: x N >= width N". Fixed by using this.width/this.height consistently after the floor assignment. Added test/bugs/bug_224.test.ts.
fix for #224
Types of changes
Checklist
Description