Feature: Separate install path from download path and add polling rate to chunk download listener#4
Open
ProRapSuperstarOriginalMaster wants to merge 3 commits intojoshuatam:gamenative-latestfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've been looking up and down the code but it's probably easier just to do the PR and show it to someone more experienced. I've created a separate (optional) download path where chunks get downloaded to, instead of to a subfolder of install path. This is to make possible the use of separate staging folders that can be used to improve download performance on slower storage mediums. My changes should mean nothing can break downstream from JavaSteam as it'll use the install path as fallback.
The only real concern I have is that the timer I've set to the chunk download listener could perhaps affect something if some downstream function for some reason relies on constant updates. It works however with GameNative without breaking anything, and seems to me to be a good fix regardless.
This version builds and clears the tests and so on. I have not tested it fully integrated into GameNative during these last 2 commits. The changes are mostly cosmetic in nature though and I assume I haven't broken anything. Hopefully this can be of use when improving things in GameNative. Best regards // "Wilhelm"
Checklist