Merged
Conversation
Owner
jpcompartir
commented
Dec 2, 2025
jpcompartir
commented
- add the 'samyds' brand to the brands functions (first pass, should be edited later by Jamie or other)
- S3 class issues following ggplot update
- remove gghalves dependency, replace with jitter in raincloud, until halves is updated for newer ggplot way of working
- fix any broken tests
…for user experience, and to allow for all files from brands/x/ to be copied over add cli:: to deps
remove bad tests in sentiment plot name cols in test-table_gt as index seems to have changed switch is.ggplot to is_ggplot in test-themes name geoms appropriately (post ggplot change?)
…bility, use jitter in dr_plot_raincloud instead. add overwrite param to dr_add_brand roxygen2 docs update theme tests to check for s3 class not type
Merge branch 'main' into feature/samybrand # Conflicts: # .DS_Store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.