Conversation
Updated the _brand.yml to what I previously had (by no means "the best"), but selfishly think this looks nice as a default. The fonts come from Google Fonts rather than anything system related- has always worked for me in the past but wanted to flag this. Also as we said previously, I don't think we need to think of the brand guidelines as bible for us, so I think Lato and Merriweather are much nicer fonts to read technical work than Helvetica.
jpcompartir
closed this pull request by merging all changes
into
jpcompartir:main
in
4b6181d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the _brand.yml to what I previously had (by no means "the best"), but selfishly think this looks nice as a default.
The fonts come from Google Fonts rather than anything system related- has always worked for me in the past but wanted to flag this. Also as we said previously, I don't think we need to think of the brand guidelines as bible for us, so I think Lato and Merriweather are much nicer fonts to read technical work than Helvetica.